Parser overhaul #247
Merged
Parser overhaul #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the refactor makes it a bit easier to read, simplifies some operations, and supports the new "semicolon in quotes" dialect entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the parsing module to be easier to follow and also incorporates the changes from #215. That is, this includes a new
semicolon in quotesdialect entry, and a regexp that is only run when needed to handle cases where there is an unescaped semicolon within an attribute's value.The refactor found some subtle bugs in the parsing that could arise in corner cases, so I think it's an improvement in functionality as well.
Additional tests have been added, in particular to check the dialects during the parser tests.