Set Prover::eval to pub, for easier debugging of circuits.
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed there's |
Development of complex constraint systems often goes wrong, and this patch allows to evaluate (for the prover) the actual value of a LinearCombination.
rubdos
changed the title
Prover::eval to pub, for easier debugging of circuits.
oleganza
reviewed
Jun 11, 2020
|
I should've noticed that I had to add a doc comment... Either way, does this need someone else to review or would this be good to go? :-) |
|
Yeah, i was waiting for CI and then went to sleep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of complex constraint systems often goes wrong, and this patch allows to evaluate (for the prover) the actual value of a LinearCombination.
Related to #278, if it doesn't even fix that.