Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Better error message for failing entry points #27530

Draft
wants to merge 1 commit into
base: sean/components/windows/missing-component-error-message
Choose a base branch
from

Conversation

smackesey
Copy link
Collaborator

@smackesey smackesey commented Feb 4, 2025

Summary & Motivation

Currently if there is an error when loading a dagster-components entry point, the whole process terminates unceremoniously with an ugly error.

This PR changes this behavior:

Entry points are loaded in a try-catch block. Any error loading an entry point causes a warning to be written to stdout about the failing entry point, and the entry point to be passed over so that the whole system doesn't blow up. The warning shows up in the dg output.

How I Tested These Changes

New unit test and manually (running dg component-type list in an env with a bad entry point).

Copy link
Collaborator Author

smackesey commented Feb 4, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant