Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components] Use get_asset_spec instead of individual methods #27521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[components] Use get_asset_spec instead of individual methods #27521

wants to merge 1 commit into from
+4 −32

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

The individual methods are now superseded, and the get_asset_spec method is way cleaner / simpler.

Plan to remove get_wrapped_translator_class above this as it doesn't provide much value anymore.

How I Tested These Changes

Changelog

NOCHANGELOG

@OwenKephart Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@OwenKephart OwenKephart requested a review from smackesey February 3, 2025 21:27
smackesey
smackesey approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smackesey smackesey smackesey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenKephart @smackesey