Drop the polyfill for the engine's findRoots - #19
Merged
Conversation
The engine now ships Workspace.findRoots (dagger/dagger#13854): the same cwd-aware project discovery this module got from github.com/dagger/polyfill — same semantics, ported from the polyfill's own design and test matrix. Swap the call, drop the dependency, and require the engine release that ships it. The engineVersion bump and the dependency removal have to land together: the version gate is what keeps the engine's new changeset behavior scoped to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io> Signed-off-by: Tom Chauveau <tom@dagger.io>
TomChv
force-pushed
the
polyfill-removal
branch
from
August 26, 2026 11:16
5bb7655 to
d766e4c
Compare
TomChv
changed the title
TomChv
marked this pull request as ready for review
August 26, 2026 11:21
TomChv
self-requested a review
August 26, 2026 11:22
Member
|
The tests passes locally but are not run by cloud check, there might be an infra issue: https://dagger.cloud/Quartz/traces/9b19c5f361c3cd39717f571b44c392b5?viewMode=trace |
TomChv
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vitest module used
dagger/polyfillto find projects below the directory where Dagger was run, plus the nearest project above it when invoked from a subdirectory.That behavior now ships natively as
Workspace.findRoots(dagger/dagger#13854, released inv1.0.0-beta.10). This PR switches the discovery call and drops the dependency. Vitest arguments, execution, and result handling do not change.Note the engine landed the API as
findRoots(markers:, exclude:), not thefindConfigDirsname this PR originally assumed.Rebased on
main, so it now also covers theincludeExtraFilessetting from #21.Test
Against a
v1.0.0-beta.10engine:dagger checkAll 8 checks pass, including ancestor and descendant discovery,
includeExtraFiles, and fixtures with expected test failures.