Add array-size check to get methods #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The are many reasons why we should sign our artifacts. The main two are: - allow library users to verify who have release the jars - maven central accepts only signed artifacts (and this is the goal) Modification: Add profile that will be activated by maven release plugin or manually with `-P sign-artifacts` option. Result: produced artifacts will be released. Acked-by: Jürgen Starek Target: master, 3.1 (cherry picked from commit 6cd0cab) Signed-off-by: Tigran Mkrtchyan <[email protected]>
Motivation: ReplyQueue uses ScheduledThreadPoolExecutor to collect expired request. However, non expired requests (those that get reply) not removed from the scheduler's queue. Modification: Configure ScheduledThreadPoolExecutor to remove canceled tasks. Add test to demonstrate this 'leak' pattern as well as improve overall test coverage. Result: Avoid potential memory leak for high number of requests with bit timeout values. Acked-by: Marina Sahakyan Target: master, 3.1 (cherry picked from commit 9328681) Signed-off-by: Tigran Mkrtchyan <[email protected]>
|
Can one of the admins verify this patch? |
|
ok to test |
|
Thanks for the fix! Can you please add |
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #84