fix: make the file name in <BaseError> wrap anywhere. #22271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
ZachJW34
reviewed
Jun 13, 2022
| @@ -12,7 +12,7 @@ | |||
| @click="onClick" | |||
| > | |||
| <i-cy-document-text_x16 class="h-16px m-12px mr-8px w-16px icon-dark-indigo-500 icon-light-indigo-100" /> | |||
| <code>{{ fileText }}</code> | |||
| <code class="fileText">{{ fileText }}</code> | |||
There was a problem hiding this comment.
Let's replace this with class="break-all". It gives us the same behavior and is a native tailwind class so we don't have to have a style tag.
| file: { | ||
| id: `FileParts:/absolute/full/path/cypress/e2e/file.cy.js`, | ||
| __typename: 'FileParts', | ||
| relative: 'veryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylong/cypress/e2e/file.cy.js', |
There was a problem hiding this comment.
For brevity:
const longFileName = `${'very'.repeat(20)}long/cypress/e2e/file.cy.js`
...
relative: longFileName
...
cy.findByText(`${longFileName}:12:25`).should('have.class', 'break-all')
ZachJW34
approved these changes
Jun 14, 2022
tbiethman
approved these changes
Jun 14, 2022
BeijiYang
pushed a commit
to BeijiYang/cypress
that referenced
this pull request
Jun 23, 2022
Co-authored-by: Zachary Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
File name in error message wrap anywhere.
Additional details
<BaseError>didn't wrap correctly. It is not a severe bug, but it's a bit annoying.Any implementation details to explain?
Steps to test
The best way to see this failure is to use the
renders the header and message slots with codeframetest atBaseError.cy.tsx. Make the relative path very long likeveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylong/cypress/e2e/file.cy.js.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?