Skip to content

chore: make create function on server.ts obsolete #18615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 1, 2021
Merged

chore: make create function on server.ts obsolete #18615

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bf641c0
fix
sainthkh Oct 25, 2021
cc1dfee
fix error
sainthkh Oct 26, 2021
1618e3a
fix error.
sainthkh Oct 26, 2021
fe91a9e
Clarify code.
sainthkh Oct 28, 2021
8d016dd
Merge branch 'develop' into remove-create-on-server-ts
emilyrohrbough Oct 28, 2021
3eb3d67
feedback
sainthkh Oct 29, 2021
27a911c
Merge branch 'develop' into remove-create-on-server-ts
emilyrohrbough Nov 1, 2021
e847284
Merge branch 'develop' into remove-create-on-server-ts
emilyrohrbough Nov 1, 2021
1968647
Merge branch 'develop' into remove-create-on-server-ts
emilyrohrbough Nov 1, 2021
4f22b0c
Merge branch 'develop' into remove-create-on-server-ts
emilyrohrbough Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/driver/src/cy/commands/xhr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Promise from 'bluebird'
import $utils from '../../cypress/utils'
import $errUtils from '../../cypress/error_utils'
import $stackUtils from '../../cypress/stack_utils'
import $Server, { Server } from '../../cypress/server'
import { Server } from '../../cypress/server'
import { $Location } from '../../cypress/location'

let server: Server | null = null
Expand Down Expand Up @@ -103,7 +103,7 @@ type XHRConsoleProps = {
const startXhrServer = (cy, state, config) => {
const logs = {}

server = $Server.create({
server = new Server({
xhrUrl: config('xhrUrl'),
stripOrigin,

Expand Down
Loading