Skip to content

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jul 29, 2025

Situation

The GitHub Actions workflow .github/workflows/main.yml is outdated, relying on Node.js 16 that entered end-of-life status on Sep 11, 2023.

The workflow triggers on push and does not use pull_request. This may miss issues if there is a delay between pushing to a branch and creating a PR, and there are environmental changes like a new Node.js release in the interim.

The CI result should also be visible in any PR. This requires setting the pull_request event trigger.

Change

  • Add an event trigger for PR to the default master branch.

Update to:

The semantic-release step remains commented out at this stage, pending follow-on PRs.

@MikeMcC399

This comment was marked as resolved.

Add event trigger for pull_request to master branch
@MikeMcC399
Copy link
Contributor Author

@AtofStryker

Please review and merge! Thank you once again!

@AtofStryker AtofStryker merged commit ecd8c34 into cypress-io:master Aug 28, 2025
1 check passed
@MikeMcC399 MikeMcC399 deleted the update/gha-main branch August 28, 2025 17:02
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants