Fix teleport to wrong instance when multiple analysis views open #2163
+24
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
May 8, 2025
Comment on lines
-125
to
+124
| :sort-input-teleport-target="toolbar?.id" | ||
| :sort-input-teleport-target="toolbarRef" |
There was a problem hiding this comment.
Avoid clashing IDs by specifying the template ref (HTML element) itself as the teleport target
MetRonnie
commented
May 8, 2025
| /** @type {import('vue').Ref<HTMLElement>} template ref */ | ||
| const toolbar = ref(null) | ||
| const toolbarRef = useTemplateRef('toolbar') | ||
|
|
There was a problem hiding this comment.
This is somewhat tangential, but is a newer (clearer IMO) way of defining template refs in Vue 3.5
oliver-sanders
approved these changes
May 8, 2025
MetRonnie
force-pushed
the
analysis-toolbar
branch
from
a604e6b to
66108d8
Compare
|
Just added a test |
MetRonnie
force-pushed
the
analysis-toolbar
branch
from
66108d8 to
f3fb6a4
Compare
oliver-sanders
added
the
data workflows team
|
Ping @JAllen42 are you able to test out that this fixes the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug not recorded in an issue.
Steps to reproduce
Open 2 analysis view tabs in the same workspace, then switch to the box plot or time series mode in the second one. You would find the sorting control does not appear here, but if you go back to the first analysis view tab it will be there instead.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.