Enhance filtering in Analysis tab #2154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+33
to
+41
| <v-text-field | ||
| id="c-analysis-filter-task-name" | ||
| clearable | ||
| placeholder="Filter by task name" | ||
| v-model.trim="tasksFilter.name" | ||
| ref="filterNameInput" | ||
| :disabled="chartType === 'timeSeries'" | ||
| v-bind="props" | ||
| /> |
There was a problem hiding this comment.
We should be able to make the space separated bit a little more intuitive.
Check out the Vuetify Combobox component, it has a multiple option that allows multiple values to be specified (note you don't have to pre-populate suggestions to a combox). It can place each item in a "chip" and allow each item to be individually clearable. It should also take care of the /\s/ stuff.
oliver-sanders
added
small
data workflows team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some feedback from users. They would like a more powerful filtering mechanism.
This change allows for multiple terms to be filtered for. The Analysis view will display all jobs that match any of the terms. Terms are separated by a space. A tool tip has been added to the filtering box to help inform users this can be done
Unit tests do not need to be updated
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.