Skip to content

log: load file incrementally #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Mar 19, 2025

Will pick up this PR sometime after #2017 (merged)
Will pick up this PR sometime after #2106 (merged)

  • Add log lines using events rather than Vue reactivity.
  • Should reduce the time taken to add a new log line from O(N) to O(1).
  • This should allow us more flexibility in choosing the batch size used to send log lines to the UI for faster large-file load in the future.
  • We were storing the log lines in a JS array AND in the DOM elements. This removes the JS array so should reduce the RAM overheads too.
  • Handle show/hide timestamps with CSS rather than JS (also allows for styling timestamps)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant