fix: add missing password field for ConnectOptions (#280)

* fix: add missing `password` field in `ConnectOptions` * fix the return type of Realm.prototype.define() Co-authored-by: dengruoqi <[email protected]>
cyjake · Feb 23, 2022 · cb308ae · cb308ae
1 parent e82f61f
commit cb308ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/test/types/realm.test.ts b/test/types/realm.test.ts
@@ -21,7 +21,7 @@ describe('=> Realm (TypeScript)', function () {
 
     it('can customize attributes with descriptors', async function() {
       const { STRING } = realm.DataTypes;
-      realm.define('User', { name: STRING }, {}, {
+      const User = realm.define('User', { name: STRING }, {}, {
         get name() {
           return this.attribute('name').replace(/^([a-z])/, function(m, chr) {
             return chr.toUpperCase();
@@ -32,6 +32,8 @@ describe('=> Realm (TypeScript)', function () {
           this.attribute('name', value);
         }
       });
+      // User.findOne should exists
+      assert(User.findOne);
     });
   });
 

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -599,6 +599,7 @@ export interface ConnectOptions {
   host?: string;
   port?: number | string;
   user?: string;
+  password?: string;
   database: string;
   models?: string | (typeof Bone)[];
   subclass?: boolean;
@@ -644,7 +645,7 @@ export default class Realm {
     attributes: Record<string, DataTypes<DataType> | AttributeMeta>,
     options?: InitOptions,
     descriptors?: Record<string, Function>,
-  ): Bone;
+  ): typeof Bone;
 
   raw(sql: string): RawSql;