incoming and out going caller name. #284
Open
+450
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve the device token for VoIP push notifications to avoid the need for users to restart the app to obtain a new device token. Removing the device token from UserDefaults caused registration failures.
fix : IOS not displaying caller number
if the user doesn't set a default caller name it will display the incoming caller number , if the already set a value user has to call [await TwilioVoice.instance.setDefaultCallerName('');] to make this work
Update the handling of the localized caller name in the `SwiftTwilioVoicePlugin.swift` file. Instead of using the `clients` dictionary to retrieve the caller name, always use the `formatUSPhoneNumber` function to format the caller's phone number. This ensures consistency and avoids potential issues with missing or incorrect caller names. Note: This commit message follows the established convention of starting with a verb in the imperative form, followed by a concise description of the changes made.
…ter to place method
# Conflicts: # android/build.gradle # android/src/main/kotlin/com/twilio/twilio_voice/TwilioVoicePlugin.kt # android/src/main/kotlin/com/twilio/twilio_voice/service/TVConnectionService.kt # android/src/main/kotlin/com/twilio/twilio_voice/types/TVMethodChannels.kt # example/ios/Runner.xcodeproj/project.pbxproj # ios/Classes/SwiftTwilioVoicePlugin.swift # ios/twilio_voice.podspec # lib/_internal/twilio_voice_web.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements to Call Handling and Management
📞 Call Management Improvements
Outgoing Caller Name Support:
callerNameparameter to theplaceCallmethod to support setting a custom caller name when initiating a call.TVConnectionService.EXTRA_CALLER_NAME.Incoming Caller Name Display:
Active Connection Cleanup:
clearActiveConnectionsinTVConnectionServiceto properly manage and clear active call connections once a call ends.🆕 New Features
TVMethodChannels.GetActiveCallOnResumeFromTerminatedStateto retrieve active call details when resuming the app after termination.✅ All features are supported on both Android and iOS, and have been thoroughly tested with my team.