-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add devcontainer feature and update setup script for CVMFS #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mv tmp.json src/cvmfs/devcontainer-feature.json | ||
|
||
- name: Publish Devcontainer Feature | ||
run: devcontainer features publish --namespace ${{ github.actor }}/${{ github.repository }} . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is not really a way to build the feature locally, build a dev container locally, and test it locally (which is weird; it's just docker stuff with a wrapper).
@vvolkl What would be the process to get the GitHub Actions release create action to have permissions (via token) to push to ghcr.io/cvmfs-contrib/github-action-cvmfs? Feel free to reach out on mattermost (wdeconin now since I got my group registered with CERN). |
@bedroge may have some advice there, we do that for the EESSI client and build containers. |
I'm not familiar with |
This PR adds a Devcontainer Feature layer configuration reusing the GitHub Action scripts.
This allows downstream users that already base their GitHub Actions on for example LCG releases to now provided online Codespaces environments that can access the LCG releases. This, in turn, allows the GitHub Copilot interactive experience inside the browser to replicate what is already possible on local VS Code systems or in GitHub Actions.
This started off as #45, but in order to streamline the
setup-cvmfs.sh
parts, we can't place thedevcontainer-feature.json
insidesrc/cvmfs/
because only the subtree starting wheredevcontainer-feature.json
is located is accessible inside the feature build (well, in the integration in the surrounding devcontainer build).Not all variables in
action.yml
are ported todevcontainer-feature.json
, since I have no way of keeping them synchronized.Devcontainers don't run autofs (well, they don't run systemd), so we have to mount specified repositories explicitly. (We could also start autofs with
service autofs start
, but that's a bit more obscure than mounting repositories.)Publishing of the Devcontainer Feature to ghcr.io as an OCI layer will need a PAT to be added as repository secret with write:packages permissions, I think.