fix: clear cache and retry on cvmfs installation failure #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
commented
Aug 25, 2025
ocaisa
reviewed
Aug 26, 2025
| sudo rm -rf /var/cache/apt/archives | ||
| sudo rm -rf /var/cache/apt/lists | ||
| sudo apt-get -q update | ||
| sudo apt-get -q -y install cvmfs |
There was a problem hiding this comment.
I know this is unlikely to fail again, but you should probably check anyway given why you are introducing this change
There was a problem hiding this comment.
Yeah, I just don't think this PR is the right solution. If you look at your original failing pipeline: https://github.com/DUNE-DAQ/daq-release/actions/runs/16244930712/job/45866367226#step:3:58, you'll see that it is already running in bash -e, so doing something like if [ $? -ne 0 ] is not going to catch this since we probably don't even return a failing exit code from apt-get install (or we would have bailed out earlier).
I have been trying to find some way to trigger this issue (GHA or locally), but no luck so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #43 by clearing the cache and retrying when
cvmfsfails to install.