Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for button on frame player that copies the current frame's filename #9081

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

archibald1418
Copy link
Contributor

@archibald1418 archibald1418 commented Feb 10, 2025

This checks that the frame filename displayed in the annotation view UI is copied to clipboard correctly
Smoke test for #8989

How has this been tested?

Use the existing Main task to trigger UI events that change clipboard contents.

Prepartion

before the test suite
  • Create main task
  • Open main task job
before each test case
  • Add a spy on the window's clipboard (has to be new every case)
    Note: Unlike mocks, spies call the real function to gain information on how this function was called

Cases

Case 1: Check that frame filename can be copied to clipboard

  • Scrape active filename
  • Press on button, confirm that both filenames are equal

Case 2: Check clipboard after switching frames

  • Switch to next frame
  • Repeat actions from Case 1

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (df5678a) to head (0f1bc84).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9081      +/-   ##
===========================================
+ Coverage    73.91%   73.93%   +0.01%     
===========================================
  Files          428      428              
  Lines        44530    44530              
  Branches      3881     3881              
===========================================
+ Hits         32916    32922       +6     
+ Misses       11614    11608       -6     
Components Coverage Δ
cvat-ui 77.47% <ø> (+0.02%) ⬆️
cvat-server 71.00% <ø> (ø)

@archibald1418 archibald1418 merged commit 7ca3a31 into develop Feb 13, 2025
34 checks passed
@archibald1418 archibald1418 deleted the ov/test-copy-frame-filename branch February 13, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants