cvat-ui: simplify code related to model label types #9074
Merged
+25
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to the Enterprise version make the following simplifications possible: * A label type may no longer be `unknown`, which means that the type of `MLModelLabel.type` can be changed to `LabelType`, and all special handling for `unknown` can be removed. * Roboflow and Hugging Face models now correctly report their label types, which makes the dedicated `return_type` field unnecessary. The `ModelReturnType` enum is unnecessary as well, as it's just an arbitrary subset of `LabelType`.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9074 +/- ##
===========================================
- Coverage 73.75% 73.73% -0.02%
===========================================
Files 428 428
Lines 44514 44519 +5
Branches 3881 3883 +2
===========================================
- Hits 32830 32825 -5
- Misses 11684 11694 +10
|
bsekachev
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Recent changes to the Enterprise version make the following simplifications possible:
A label type may no longer be
unknown, which means that the type ofMLModelLabel.typecan be changed toLabelType, and all special handling forunknowncan be removed.Roboflow and Hugging Face models now correctly report their label types, which makes the dedicated
return_typefield unnecessary. TheModelReturnTypeenum is unnecessary as well, as it's just an arbitrary subset ofLabelType.How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.