Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track interpolation in tasks with deleted frames #9059

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Follow-up for #8834.

If a task or a job contains deleted frames that contain track keyframes, these keyframes should be excluded from the interpolation. However, in jobs having specific frames included (e.g. GT jobs), deleted frames should not be confused with included frames during track interpolation. Deleted frames should affect existing shapes in tracks, while included frames should only filter the resulting annotations after interpolation. This PR implements this approach.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max changed the title Fix track interpolation in tasks with deleted frames [WIP] Fix track interpolation in tasks with deleted frames Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@1872b51). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9059   +/-   ##
==========================================
  Coverage           ?   73.74%           
==========================================
  Files              ?      428           
  Lines              ?    44516           
  Branches           ?     3881           
==========================================
  Hits               ?    32827           
  Misses             ?    11689           
  Partials           ?        0           
Components Coverage Δ
cvat-ui 77.44% <ø> (?)
cvat-server 70.68% <100.00%> (?)

@zhiltsov-max zhiltsov-max changed the title [WIP] Fix track interpolation in tasks with deleted frames Fix track interpolation in tasks with deleted frames Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
20.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants