Added ability to customize logo and title #9052
Open
+70
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9052 +/- ##
===========================================
+ Coverage 73.42% 73.72% +0.30%
===========================================
Files 419 428 +9
Lines 44351 44507 +156
Branches 3875 3875
===========================================
+ Hits 32563 32812 +249
+ Misses 11788 11695 -93
|
|
nmanovic
reviewed
Feb 5, 2025
| @@ -189,6 +189,12 @@ | |||
| _DATA_UPDATED_DATE_HEADER_NAME = 'X-Updated-Date' | |||
| _RETRY_AFTER_TIMEOUT = 10 | |||
|
|
|||
| ICON_FILE = "assets/logo.svg" | |||
|
|
|||
| def get_logo() -> str: | |||
There was a problem hiding this comment.
Please check that we don't read it on every about request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This simple PR moves logo management to
/aboutserver endpoint. It would make easier to change it if needed by replacinglogo.svgasset on the server. Additinally, there is a possibility to edit title and description using settingsHow has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.