Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed frame name text & tooltip in case of large names #9043

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Feb 3, 2025

Motivation and context

There are two problems with frame filename in player:

  • There is no 'ellipsis' if filename is large
  • The tooltip appears in wrong position if filename is large
    image

With fix of the frame name styles:
image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov requested a review from bsekachev as a code owner February 3, 2025 13:24
@klakhov klakhov added the ui/ux label Feb 3, 2025
@klakhov klakhov requested review from bsekachev and removed request for bsekachev February 3, 2025 13:24
Copy link

sonarqubecloud bot commented Feb 3, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (9892390) to head (7be9f68).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9043      +/-   ##
===========================================
+ Coverage    73.40%   73.42%   +0.01%     
===========================================
  Files          418      419       +1     
  Lines        44340    44351      +11     
  Branches      3870     3875       +5     
===========================================
+ Hits         32548    32563      +15     
+ Misses       11792    11788       -4     
Components Coverage Δ
cvat-ui 77.40% <ø> (+0.03%) ⬆️
cvat-server 70.11% <ø> (ø)

@klakhov klakhov merged commit cae4e8f into develop Feb 4, 2025
34 checks passed
@klakhov klakhov deleted the kl/improve-tooltip branch February 4, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants