Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run Stylelint on all files, not just changed ones #9042

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Feb 3, 2025

Motivation and context

This is the equivalent of #5720, but for Stylelint. Inspired by the CI failures in #8998.

Fix all remaining Stylelint warnings, so that CI stays green.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

This is the equivalent of cvat-ai#5720, but for Stylelint. Inspired by the CI
failures in cvat-ai#8998.

Fix all remaining Stylelint warnings, so that CI stays green.
@SpecLad SpecLad requested a review from bsekachev as a code owner February 3, 2025 13:20
Copy link

sonarqubecloud bot commented Feb 3, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (21901a3) to head (540e94a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9042      +/-   ##
===========================================
- Coverage    73.41%   73.41%   -0.01%     
===========================================
  Files          418      419       +1     
  Lines        44340    44351      +11     
  Branches      3870     3875       +5     
===========================================
+ Hits         32553    32561       +8     
- Misses       11787    11790       +3     
Components Coverage Δ
cvat-ui 77.39% <ø> (-0.01%) ⬇️
cvat-server 70.11% <ø> (ø)

@bsekachev bsekachev merged commit 908a47d into cvat-ai:develop Feb 3, 2025
34 checks passed
@SpecLad SpecLad deleted the stylelint-all branch February 3, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants