Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a button to frame player to copy filename #8989

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Jan 24, 2025

Motivation and context

Added a simple button to quickly copy frame name.

Resolved #7237

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov added the ui/ux label Jan 24, 2025
@klakhov klakhov requested a review from bsekachev as a code owner January 24, 2025 11:36
@klakhov klakhov requested a review from nmanovic as a code owner January 24, 2025 12:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.40%. Comparing base (7e3f802) to head (0aa1710).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8989      +/-   ##
===========================================
+ Coverage    73.39%   73.40%   +0.01%     
===========================================
  Files          415      416       +1     
  Lines        44192    44198       +6     
  Branches      3859     3860       +1     
===========================================
+ Hits         32435    32445      +10     
+ Misses       11757    11753       -4     
Components Coverage Δ
cvat-ui 77.38% <66.66%> (+0.02%) ⬆️
cvat-server 70.09% <ø> (ø)

Copy link
Member

@bsekachev bsekachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to add a piece of documentation?

Copy link

@klakhov klakhov merged commit aeefbee into develop Jan 29, 2025
34 checks passed
This was referenced Jan 29, 2025
@klakhov klakhov deleted the kl/copy-frame-name-button branch January 31, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy image file name to clipboard
3 participants