Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jest tests from cvat-core #8985

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Remove jest tests from cvat-core #8985

merged 3 commits into from
Jan 24, 2025

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 23, 2025

Motivation and context

From retrospective these tests are more useless. Typical scenario of them failing is updated server schema when server changed REST API, we updated cvat-core and everything works, but these tests fail as all the data in hardcoded and almost never updated. So, we decided to remove them as now we cover the whole client app using Cypress end-to-end testing.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (4191be3) to head (da81e2b).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8985      +/-   ##
===========================================
- Coverage    73.90%   73.38%   -0.52%     
===========================================
  Files          417      415       -2     
  Lines        44598    44184     -414     
  Branches      4031     3859     -172     
===========================================
- Hits         32960    32426     -534     
- Misses       11638    11758     +120     
Components Coverage Δ
cvat-ui 77.35% <ø> (-1.05%) ⬇️
cvat-server 70.08% <ø> (ø)

@bsekachev bsekachev merged commit d8ce29d into develop Jan 24, 2025
34 checks passed
@bsekachev bsekachev deleted the bs/drop_jest branch January 24, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants