Validate label types in the serializer #8980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
labeltype-choicefield
branch
from
9a3deb7 to
1ab0e42
Compare
SpecLad
force-pushed
the
labeltype-choicefield
branch
2 times, most recently
from
7e8082a to
635cd52
Compare
Also, make `NULL` an invalid label type value, since it seems to be redundant with `any`.
SpecLad
force-pushed
the
labeltype-choicefield
branch
from
635cd52 to
89bb3b9
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8980 +/- ##
========================================
Coverage 73.84% 73.84%
========================================
Files 417 417
Lines 44591 44602 +11
Branches 4031 4031
========================================
+ Hits 32927 32938 +11
Misses 11664 11664
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This prevents users from creating labels with unrecognized types.
Along the way, this also fixes the backend
LabelTypeenum to actually correspond to the label types that UI uses. The necessary changes are:bboxtorectangle;mask;cuboid_3d.How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.