Skip to content

Add r treesitter #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

Add r treesitter #97

merged 4 commits into from
May 14, 2025

Conversation

BlueDrink9
Copy link
Contributor

Sadly I was unable to get this to actually build, across two different distros. I presume this is to do with the current "cursed state" of the repo? Is this an issue for merging?

I seem to have an old version of treesitter, 0.22.6, related to this issue #93 (comment)

the error I get is the same:

Failed to locate a package.json file that has a "tree-sitter" section, please ensure you have one, and if you don't then consult the docs

@BlueDrink9 BlueDrink9 requested a review from a team as a code owner February 23, 2025 00:58
@BlueDrink9
Copy link
Contributor Author

I think I'm blocked adding r support to cursorless until this is merged, because I can't get it to build locally

@pokey
Copy link
Member

pokey commented Feb 26, 2025

out unfortunately I think the answer is #93 (comment). I don't have capacity to work on at this moment but if you want to take a crack I can help you get up to speed.

@pokey
Copy link
Member

pokey commented May 1, 2025

Ok we've moved all the wasm stuff into https://github.com/cursorless-dev/tree-sitter-wasms so you can move the package.json dependency piece there and then we'll release a new version of that package. That way you don't need to worry about building wasms; it happens in CI

@BlueDrink9
Copy link
Contributor Author

Waiting on cursorless-dev/tree-sitter-wasms#17 which in turn is waiting on a npm package.

@BlueDrink9 BlueDrink9 closed this May 13, 2025
@BlueDrink9
Copy link
Contributor Author

@AndreasArvidsson does this repo AND cursorless need to be updated for the new wasms to appear? Is there a way to use a local build of parse tree with cursorless?

@BlueDrink9 BlueDrink9 reopened this May 13, 2025
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented May 14, 2025

Yes. This repository uses the wasm and Cursorless uses this extension.
You can run the build script and manually install a new version of this extension

"build": "vsce package -o build.vsix",

But normally you would just use the Run extension launch config and try out the changes in the extension host.

@AndreasArvidsson AndreasArvidsson merged commit b48027f into cursorless-dev:main May 14, 2025
@AndreasArvidsson
Copy link
Member

Published

@BlueDrink9
Copy link
Contributor Author

~/.vscode/extensions/pokey.parse-tree-0.37.0-universal/parsers has no tree-sitter-r.wasm, so I think this might have failed to build maybe? 0.37.0 is the version that was just released

@BlueDrink9
Copy link
Contributor Author

Oh sorry Andreas, it looks like at some point I overwrote my changes to the package json and it did not update the wasms dependency

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented May 14, 2025

Oh my bad. I should have double check that. Do you mind creating a new pull request on this repository with dependency "@cursorless/tree-sitter-wasms": "0.3.0"?
Also bump version to 0.37.1

@BlueDrink9
Copy link
Contributor Author

oh, I thought I had, but it isn't there. Must have forgot to confirm it. Done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants