Skip to content

Fix TcpFakeServer EVALSHA NOSCRIPT error handling #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix TcpFakeServer EVALSHA NOSCRIPT error handling #433

wants to merge 2 commits into from

Conversation

@oliverhaas
Copy link

  • Add NOSCRIPT prefix to NoScriptError messages in TCP protocol
  • Add test for EVALSHA with missing script

See #432

@oliverhaas oliverhaas requested a review from cunla as a code owner October 28, 2025 21:17
@oliverhaas
Fix TcpFakeServer EVALSHA NOSCRIPT error handling
31591ad 
- Add NOSCRIPT prefix to NoScriptError messages in TCP protocol
- Add test for EVALSHA with missing script
@oliverhaas oliverhaas force-pushed the fix-tcp-server-evalsha-noscript branch from d70fbc5 to 31591ad Compare October 28, 2025 21:18
@cunla
Copy link
Owner

cunla commented Nov 2, 2025

Hi, thanks for bringing this up.
I implemented a more holistic implementation of this in the master branch - addressing all exception types.
Please update your fork with the test, and I'll merge the PR.

Thanks again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cunla cunla Awaiting requested review from cunla cunla is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverhaas @cunla