Add custom UuidGenerator to Runtime.Builder #3039
Merged
+93
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the UuidGenerator is looked up by SPI when creating the event bus. This requires the UuidGenerator to be part of the classloader what might not always be the case. This now adds an option to set an actual instance for the UuidGenerator and uses that in case it is specified.
|
@laeubi do you still need this? I'm looking at cucumber/cucumber-eclipse@12e829e and I see that you're using the |
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UuidGenerator is looked up by SPI when creating the event bus. This requires the UuidGenerator to be part of the classloader what might not always be the case.
This now adds an option to set an actual instance for the UuidGenerator and uses that in case it is specified.