Repository navigation
Conversation
Cucumber-Ruby 7.1 and 10 send a doc string as an additional string argument in the invoke request, which the existing tests for string arguments already cover. Add a test for a doc string that spans multiple lines and contains indentation and quotes, and check that a step definition receives such a doc string unchanged. Assisted-by: Claude Code
Show how a step definition receives a doc string: as the last argument, after the regex parameters. The steps check the received text exactly, including line breaks and indentation, for a doc string without and with content type and for one following a regex parameter. The content type itself is not sent over the wire. As the functional tests run this example, they also check that the doc strings arrive unchanged over the wire. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add doc string tests and example to verify handling of multiline doc strings and ensure compatibility with Cucumber-Ruby. Analysis, implementation, and tests were realized with Claude Code. Manual tests and reviews were done for all changes.
Details
handlesInvokeMessageWithMultilineDocStringArg: Validates multiline doc strings with indentation and quotes.passesDocStringArgToStepDefinition: Ensures doc strings are passed unchanged throughWireProtocolHandlerandCukeEngineImpl.FeatureShowcasecovering scenarios without/with content type and one after a regex parameter.Motivation and Context
The README currently warns about a bug in the wire protocol implementation (cucumber/cucumber-ruby#1183). While the underlying bug was fixed in Cucumber-Ruby 2.1.0, this repository lacked doc string coverage. This PR adds tests and examples to verify functionality. The README warning removal is handled separately in PR #320.
How Has This Been Tested?
CUKE_STRICT=on).ctest 113/113).git merge-tree).Types of changes
Checklist: