Track Backports for 0.32.3 in our Fork#1
Open
ovr wants to merge 10 commits into
Open
Conversation
ovr
force-pushed
the
cubestore-0.32.3-backport
branch
from
April 25, 2024 22:19
9dcac87 to
a6feb8d
Compare
ovr
force-pushed
the
cubestore-0.32.3-backport
branch
from
April 25, 2024 22:32
8c83fb2 to
be20af5
Compare
Bucket::set_server_side_encryption(Some("AES256")) sends the header only
on PutObject and InitiateMultipartUpload requests. S3 rejects the header
on read/list/UploadPart operations (parts inherit the encryption declared
at initiation), so setting it bucket-wide via extra_headers breaks every
non-PUT request — S3 returns an error XML that list parsing chokes on.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…SSE header put_object_stream issues part uploads as PutObject with multipart:Some rather than Command::UploadPart, so the header was still sent on parts — S3 rejects it there (HTTP 400), breaking every multipart upload with SSE configured (observed on a 210MB metastore WAL: init + small PUTs fine, parts 400). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
feat: per-operation x-amz-server-side-encryption support on Bucket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not planned to be merged. Only for tracking!