-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(tesseract): stop a rolling window's plan fanning out across measures #11824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
waralexrom
wants to merge
6
commits into
master
Choose a base branch
from
tesseract-rolling-window-fanout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
85fe210
test(tesseract): add rolling-window fan-out reproduction for #11770
claude 6b2c92a
fix(tesseract): bound a rolling window's base scan by literals
waralexrom 923c73e
fix(tesseract): share a rolling window's base scan across measures
waralexrom e5b2952
fix(tesseract): decline the series bounds a non-date range carries
waralexrom 35990ae
fix(tesseract): keep a shared base scan out of the paths that cannot …
waralexrom 2ac4739
fix(tesseract): let a rollup per rolling measure outrank a shared scan
waralexrom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 17 additions & 2 deletions
19
rust/cube/cubesqlplanner/cubesqlplanner/src/planner/filter/operators/rolling_window.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, not a blocker: the two branches this now chooses between are not timezone-equivalent.
format_and_allocate_from_date/to_daterun the value throughapply_db_time_zone, anduse_db_time_zoneis!filters_ctx.use_local_tz— true in the common case. The fallbackdate_range_from_time_seriesreadsmin("date_from")/max("date_to")straight off thetime_seriesCTE, whose boundsTimeSeries::to_sqlemits as barequote_string(from_date)with no tz wrapping.So under a non-UTC
CUBEJS_DB_TIME_ZONEthe literal path shifts the base-scan bounds and the sub-select path does not. The literal path is arguably the correct one (it matches how every other date-range filter renders), but that also means this PR silently changes the base-scan window for those setups, and the Postgres integration runs quoted in the description would not catch it if they run in UTC. Is there a rolling-window test with a db timezone set?