Skip to content

docs: dashboard link drill-ins honor explicit target (v1.7.5+)#11348

Open
mngr wants to merge 1 commit into
masterfrom
docs/dashboard-link-target-honored
Open

docs: dashboard link drill-ins honor explicit target (v1.7.5+)#11348
mngr wants to merge 1 commit into
masterfrom
docs/dashboard-link-target-honored

Conversation

@mngr

@mngr mngr commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to the frontend change that lets dashboard: drill-in links honor an explicit target (CUB-3339), now that the runtime only emits target when the model sets it (CORE-566 fix, #11294, shipped in v1.7.5).

The dimension links docs still described the old workaround behavior — that drill-ins always navigate in-app and ignore target. Updated to the current contract:

  • url: links → default blank (new tab); explicit target honored (unchanged)
  • dashboard: drill-ins → default self (in-app); explicit target now honored (blank = new tab, self = same tab); Cmd/Ctrl-click still forces a new tab
  • Honoring an explicit target on a drill-in requires v1.7.5+ — older runtimes always navigate drill-ins in-app

Changes

  • docs-mintlify/docs/data-modeling/dimensions.mdxtarget parameter row + Behavior → "Drill-in vs external" bullet
  • docs-mintlify/reference/data-modeling/dimensions.mdxtarget description

🤖 Generated with Claude Code

@mngr
mngr requested a review from keydunov as a code owner July 24, 2026 22:20
@claude

claude Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mngr's task in 20s —— View job


Review: docs — dashboard drill-in target (v1.7.5+)

Verdict: LGTM. Docs-only change; accurate, self-consistent, and clearly notes the version gate.

Details
  • Read diff
  • Cross-check both files for consistency
  • Verify version-gate wording

What works

  • Table row (dimensions.mdx:411) and Behavior bullet (:513-520) agree: url: defaults to blank, dashboard: defaults to self, explicit target honored on both, drill-in honoring requires v1.7.5+.
  • Reference page (reference/data-modeling/dimensions.mdx:456-460) mirrors the same contract concisely.
  • Cmd/Ctrl-click override is called out — good for user expectations.
  • Version gate (v1.7.5+) is stated in both the table row and the Behavior bullet, so readers landing in either place get it.

Minor nits (non-blocking)

  • The table row (dimensions.mdx:411) is now a fairly dense sentence packing default-by-kind + version gate + link into one cell. Readable, but if you want a lighter touch you could drop the parenthetical version note there and rely on the Behavior bullet — the reference page already does this split cleanly.
  • Reference page doesn't mention the Cmd/Ctrl-click override. Probably fine since the docs page carries the fuller behavior spec, but worth a beat of thought.

No security/perf/test surface — docs only.

• `docs/dashboard-link-target-honored`

@github-actions github-actions Bot added the pr:community Contribution from Cube.js community members. label Jul 24, 2026
@mintlify

mintlify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 24, 2026, 10:24 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant