Add support to mapping between internal and external IP's and Validate fileds from 'SENTINEL sentinels' command#53
Open
erezleaks wants to merge 4 commits intoctstone:masterfrom
Open
Add support to mapping between internal and external IP's and Validate fileds from 'SENTINEL sentinels' command#53erezleaks wants to merge 4 commits intoctstone:masterfrom
erezleaks wants to merge 4 commits intoctstone:masterfrom
Conversation
2. Validate fileds from 'SENTINEL sentinels' command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case sentinels are communicating with each other with internal IP there is a need to add host mapping to external IP so when sentinel returns the IP of redis master it will be accessible for hosts out side.
Usage example:
var sentinel = new RedisSentinelManager(new string[]{ "10.0.0.1:26379", "10.0.0.2:26379", "10.0.0.3:26379"});sentinel.AddHostMapping(new System.Collections.Generic.Dictionary<string, string> { { "10.0.0.1", "35.36.37.38" }, { "10.0.0.2", "35.36.37.39" }, { "10.0.0.3", "35.36.37.40" } });In addition, fix renamed or moved fields in 'SENTINEL sentinel' command.
for example see "pending-commands" => "link-pending-commands":
https://groups.google.com/forum/#!topic/redis-db/24GIAEvW9VU