Skip to content

Fix views made with whitespace-only names (D1060) #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pawelwlod wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix views made with whitespace-only names (D1060) #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9dde7
Fix views made with whitespace-only names
Dec 3, 2025
1f7962e
Update error message to improve clarity
Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/GADS/View.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ sub write
length $self->name < 128
or error __"View name must be less than 128 characters";

# Names consisting of just whitespace characters cause issues when displaying a view
$self->name !~ /^\s*$/
or error __"View name must not contain only whitespace characters";

my $global = !$self->layout->user ? 1 : $self->global;

$self->clear_writable; # Force rebuild based on any updated values
Expand Down