Skip to content

[fips-8-legacy] Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bmastbergen
Copy link
Collaborator

Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm

jira VULN-8772
cve CVE-2022-42896
commit-author Luiz Augusto von Dentz <[email protected]>
commit f937b758a188d6fd328a81367087eddbb2fce50f

l2cap_global_chan_by_psm shall not return fixed channels as they are not meant to be connected by (S)PSM.

	Signed-off-by: Luiz Augusto von Dentz <[email protected]>
	Reviewed-by: Tedd Ho-Jeong An <[email protected]>
(cherry picked from commit f937b758a188d6fd328a81367087eddbb2fce50f)
	Signed-off-by: Brett Mastbergen <[email protected]>

Same change made to lts8.6 #78

Build log
build.log

Kernel selftests before and after
selftests-before.log
selftests-after.log

jira VULN-8772
cve CVE-2022-42896
commit-author Luiz Augusto von Dentz <[email protected]>
commit f937b75

l2cap_global_chan_by_psm shall not return fixed channels as they are not
meant to be connected by (S)PSM.

	Signed-off-by: Luiz Augusto von Dentz <[email protected]>
	Reviewed-by: Tedd Ho-Jeong An <[email protected]>
(cherry picked from commit f937b75)
	Signed-off-by: Brett Mastbergen <[email protected]>
@PlaidCat
Copy link
Collaborator

@bmastbergen Could you pull in the Pull_request changes to the githubactions as well to this branch?

We also don't need aarch64 for them.
09c1637

@bmastbergen
Copy link
Collaborator Author

@bmastbergen Could you pull in the Pull_request changes to the githubactions as well to this branch?

We also don't need aarch64 for them. 09c1637

Yes, will add

@PlaidCat
Copy link
Collaborator

@bmastbergen Could you pull in the Pull_request changes to the githubactions as well to this branch?
We also don't need aarch64 for them. 09c1637

Yes, will add

Thanks also sorry, we need to remove the following with git rm

push-check_*.yml
process-pull-request.yml (this is getting replaced)

@bmastbergen bmastbergen force-pushed the bmastbergen_fips-legacy-8-compliant/4.18.0-425.13.1/VULN-8772 branch 2 times, most recently from b409b6c to e45dada Compare January 27, 2025 21:44
@PlaidCat PlaidCat changed the title [fips8.6] Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm [fips-8-legacy] Bluetooth: L2CAP: Fix l2cap_global_chan_by_psm Jan 27, 2025
Since we need to make sure external contributors code actually compiles
prior to merging. To get access to the forked repos merge request we
need to switch over our push to pull_request. In addition we're fixing up
some Naming Conventions, adding aarch64 to this branch and fixing the naming
so that we can quickly identify if the CI is for x86_64.

Also disable the process-pull-request until the `utf-8` situation is
resolved.
@bmastbergen bmastbergen force-pushed the bmastbergen_fips-legacy-8-compliant/4.18.0-425.13.1/VULN-8772 branch from e45dada to ff4b155 Compare January 27, 2025 21:52
Copy link
Collaborator

@PlaidCat PlaidCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@gvrose8192 gvrose8192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

@bmastbergen bmastbergen merged commit b9b915c into fips-legacy-8-compliant/4.18.0-425.13.1 Jan 27, 2025
1 check passed
@bmastbergen bmastbergen deleted the bmastbergen_fips-legacy-8-compliant/4.18.0-425.13.1/VULN-8772 branch January 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants