Skip to content

Conversation

pendula95
Copy link
Contributor

Patch for CVE-2024-3596 to send all responses with Message-Authenticator Attribute. This patch only handles adding attribute in responses. For full fix we need to also validate Message-Authenticator Attribute when decoding packages.

@mdbsaleem
Copy link

mdbsaleem commented Jan 21, 2025

@pendula95 I tried the patch fix. It seems a line of code is missing to be added without which the message authenticator attribute is 0's. When I add the call as below it returns the Message-Authenticator correctly.

attributes = getAttributeBytes();
DataOutputStream dos = new DataOutputStream(out);
dos.writeByte(getPacketType());
dos.writeByte(getPacketIdentifier());
dos.writeShort(packetLength);
dos.write(getAuthenticator());

@kaustubhDsarathi
Copy link

@mdbsaleem but it's already set at this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants