Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VeDirectFrameHandler.cpp #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FROeHlyEisvogel
Copy link

Add frameLen checking to avoid crashes

Add frameLen checking to avoid crashes
if (frameIndex < frameLen) {
strcpy(tempName[frameIndex], mName); // copy name to temporary buffer
strcpy(tempValue[frameIndex], mValue); // copy value to temporary buffer
frameIndex++;
Copy link

@redPanther redPanther Oct 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to move frameIndex++; after if block, otherwise I get chrashes constantly.
with:

void VeDirectFrameHandler::textRxEvent(char * mName, char * mValue) {
        if (frameIndex < frameLen) {
                strcpy(tempName[frameIndex], mName);    // copy name to temporary buffer
                strcpy(tempValue[frameIndex], mValue);  // copy value to temporary buffer
         }
        frameIndex++;
}

it works perfectly

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redPanther - what Victron device are you talking to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants