Merged
Conversation
Contributor
xgraceyan
commented
Feb 6, 2026
xgraceyan
commented
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexespejo
reviewed
Feb 6, 2026
| title: string; | ||
| } | ||
|
|
||
| const recruitmentEvents: TimelineEvent[] = [ |
Member
There was a problem hiding this comment.
nit: there's a pattern in the project where constants are stored in a file I don't remember the name of so that future webmasters can just change those files
alexespejo
requested changes
Feb 6, 2026
|
|
||
| export const RECRUITMENT_EVENTS: RecruitmentEvent[] = [ | ||
| { | ||
| date: "September 21, 2025", |
Member
There was a problem hiding this comment.
Nit: Might be overkill but maybe there's a way to create a utility that will make the dates dumb proof so all the dates can be configured in one variable or somn. Lwky dtm I just felt like commenting something :p
Contributor
Author
There was a problem hiding this comment.
Ya idk exactly wym but i made the dates not strings so hopefully its easier to edit. a bit dtm tho i think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.