CW2-7-move-social-media-to-footer #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu04
approved these changes
May 8, 2024
Contributor
derekxu04
left a comment
derekxu04
left a comment
There was a problem hiding this comment.
Sorry for late review but looks good! Feel free to resolve conflicts and merge.
Details that can be discussed later unless you feel strongly about it
- Do we want links to open a new tab? I'm leaning towards yes
- Definitely want to make the links (and the general footer bigger probably), but this can be left to later probably
PenTest-duck
pushed a commit
that referenced
this pull request
May 30, 2024
CW2-7-move-social-media-to-footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes are required?
As specified.
Changes
Screenshots
Comments