hw3 commit

[euphoricpoptarts]

Michael Gilbert 44823653

[pragdave]

No deduction, but watch out for layout—I'd like to see a space after commas.

[pragdave]

-6

I'm being a little tough here, but the instructions asked you to use an agent for this, rather than writing your own GenServer.

+2

Then I'm being a softie because you wrote your own GenServer

[pragdave]

-5 for style/complexity

I'm uncomfortable with the number of variables, and the general linear nature of this code.

I'd rather have seen something like:

  defp into_chunks(collection, count) do
    chunk_size = div(Enum.count( collection), count )
    Enum.chunk_every( collection, chunk_size)
  end

  def pmap(collection, process_count, function) do
    chunk_mapper = &( Task.async( fn -> Enum.map( &1, function) end ) )

    collection
    |> into_chunks(process_count)
    |> Enum.map( chunk_mapper )
    |> Enum.map( &( Task.await( &1 ) ) )
    |> Enum.concat()
  end