fix(react): Button Loading State Logic #501
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkwid is attempting to deploy a commit to the Personal Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
According to this comment, I opened PR here (park-ui). |
hkwid
changed the title
Author
|
more than 100 days no response... 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logic issue in the Button component where loadingText would always be displayed when provided, regardless of the loading state. The correct behavior is to only show loadingText when the button is in a loading state.
Changes
Updated the conditional rendering logic in the Button component
The component now correctly:
Shows loadingText if loading=true and loadingText exists
Shows spinner with invisible children if loading=true and no loadingText
Shows children if loading=false, regardless of loadingText value