Improved exception handling#8
Merged
Merged
Conversation
glpatcern
force-pushed
the
exception-handling
branch
from
September 13, 2024 14:05
523563e to
f8f393c
Compare
2 tasks
rawe0
reviewed
Sep 17, 2024
rawe0
left a comment
rawe0
left a comment
Member
There was a problem hiding this comment.
Some comments provide context as to why things were done a certain way, the rest of the changes look good, makes sense to standardize the exception messages, if more info is needed they can check the logs.
I hope it's okay I send the review, it's fun to see it is being used :)
glpatcern
marked this pull request as draft
September 18, 2024 06:51
glpatcern
marked this pull request as ready for review
September 23, 2024 08:15
diocas
requested changes
Sep 25, 2024
glpatcern
force-pushed
the
exception-handling
branch
from
October 1, 2024 14:20
15f0dea to
1985cdc
Compare
glpatcern
commented
Oct 22, 2024
Member
Author
|
@diocas this is good for review/merge (GitHub tells me that there are conflicts but I fixed them), can you please have a look? |
diocas
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some refactoring of the exceptions and some minor fixes, following full tests of the wopiserver - cf. cs3org/wopiserver#161