Skip to content

WIP: Add acknowledgements section. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

WIP: Add acknowledgements section. #175

merged 2 commits into from
May 21, 2025

Conversation

mickenordin
Copy link
Collaborator

I am making this a wip pr in case I have missed someone who should be mentioned.

@mickenordin
WIP: Add acknowledgements section.
ea46888 
I am making this a wip pr in case I have missed someone who should be
mentioned.
@mickenordin
Copy link
Collaborator Author

I suppose we ought to mention Geant and NL-net as well? Some other organization?

glpatcern
glpatcern approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickenordin I see you went through really the full history, definitely I don't have further names to add. Just a couple of comments:

@glpatcern
Copy link
Member

I suppose we ought to mention Geant and NL-net as well? Some other organization?

For that, I'm not sure: we'd have to either mention the affiliation of everyone, or none of them.

MahdiBaghbani
MahdiBaghbani reviewed May 16, 2025
View reviewed changes
@mickenordin
Copy link
Collaborator Author

I suppose we ought to mention Geant and NL-net as well? Some other organization?

For that, I'm not sure: we'd have to either mention the affiliation of everyone, or none of them.

I was thinking that we should thank those two orgs specifically because of direct contribution of money, but I am happy to exclude such a section too.

@mickenordin
Address feedback
747fa3d 
Remove duplicate name, remove testsuite section and drop the xml file
that now will be generated in ci.
@mickenordin mickenordin marked this pull request as ready for review May 21, 2025 13:50
@mickenordin mickenordin merged commit 2663aa9 into develop May 21, 2025
glpatcern added a commit that referenced this pull request May 22, 2025
@glpatcern
Add acknowledgements section. (#175)
21fad1d 
(Re-committed to resume the xml version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBaghbani MahdiBaghbani MahdiBaghbani left review comments

@michielbdejong michielbdejong michielbdejong approved these changes

@glpatcern glpatcern glpatcern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickenordin @glpatcern @michielbdejong @MahdiBaghbani