Skip to content

Build architecture-agnostic docker images #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −35
Open

Build architecture-agnostic docker images #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5757cf6
Build architecture-agnostic docker images
straight-shoota Nov 20, 2025
57e7655
Use `TARGETARCH
straight-shoota Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 17 additions & 27 deletions docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
# Recipies for this Makefile

## Build all docker images
## $ make DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z CRYSTAL_TARGZ=...
## $ make DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z
## Build ubuntu64 docker images
## $ make ubuntu64 DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z CRYSTAL_TARGZ=...
## $ make ubuntu64 DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z
## Build alpine docker images
## $ make alpine DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z CRYSTAL_TARGZ=...
## $ make alpine DOCKER_TAG=nightly CRYSTAL_VERSION=0.xy.z

CRYSTAL_VERSION ?= ## How the binaries should be branded
CRYSTAL_TARGZ ?= ## Which crystal.tar.gz file to install in docker images (ubuntu64, alpine)
TARBALLS ?= tarballs## Path to folder which contains the Crystal tarballs to install in docker images.

DOCKER_TAG ?= $(CRYSTAL_VERSION)## How to tag the docker image (examples: `0.27.2`, `nightly20190307`). `-build` will be appended for build images.
DOCKER_REPOSITORY ?= crystallang/crystal## Docker hub repository to commit image

OUTPUT_DIR := build
BUILD_CONTEXT := $(CURDIR)/build-context
BUILD_ARGS_UBUNTU64 := --build-arg crystal_targz=crystal.tar.gz $(BUILD_CONTEXT)/ubuntu64
BUILD_ARGS_ALPINE := --build-arg crystal_targz=crystal.tar.gz $(BUILD_CONTEXT)/alpine
BUILD_CONTEXT := build-context
DOCKER_TAG_UBUNTU := $(DOCKER_REPOSITORY):$(DOCKER_TAG)
DOCKER_TAG_ALPINE := $(DOCKER_REPOSITORY):$(DOCKER_TAG)-alpine

Expand All @@ -36,36 +34,28 @@ alpine: ## Build alpine images
alpine: $(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine.tar.gz
alpine: $(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine-build.tar.gz

$(BUILD_CONTEXT)/ubuntu64: ubuntu.Dockerfile $(BUILD_CONTEXT)/ubuntu64/crystal.tar.gz
cp ubuntu.Dockerfile $@/Dockerfile
$(BUILD_CONTEXT)/crystal-amd64.tar.gz: $(TARBALLS)/crystal-$(CRYSTAL_VERSION)-1-linux-x86_64.tar.gz | $(BUILD_CONTEXT)
cp $< $@

$(BUILD_CONTEXT)/alpine: alpine.Dockerfile $(BUILD_CONTEXT)/alpine/crystal.tar.gz
cp alpine.Dockerfile $@/Dockerfile
mkdir $@/files/

%/crystal.tar.gz:
mkdir -p $(shell dirname $@)
cp $(CRYSTAL_TARGZ) $@

$(OUTPUT_DIR):
mkdir -p $(OUTPUT_DIR)
$(OUTPUT_DIR) $(BUILD_CONTEXT):
mkdir -p $@

# Ubuntu x86_64
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-ubuntu-x86_64.tar.gz: $(BUILD_CONTEXT)/ubuntu64 $(OUTPUT_DIR)
docker build -t $(DOCKER_TAG_UBUNTU) --target runtime $(BUILD_ARGS_UBUNTU64)
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-ubuntu-x86_64.tar.gz: ubuntu.Dockerfile $(BUILD_CONTEXT)/crystal-amd64.tar.gz $(OUTPUT_DIR)
docker build --file ubuntu.Dockerfile -t $(DOCKER_TAG_UBUNTU) --target runtime $(BUILD_CONTEXT)
docker save $(DOCKER_TAG_UBUNTU) | gzip > $@

$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-ubuntu-x86_64-build.tar.gz: $(BUILD_CONTEXT)/ubuntu64 $(OUTPUT_DIR)
docker build -t $(DOCKER_TAG_UBUNTU)-build --target build $(BUILD_ARGS_UBUNTU64)
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-ubuntu-x86_64-build.tar.gz: ubuntu.Dockerfile $(BUILD_CONTEXT)/crystal-amd64.tar.gz $(OUTPUT_DIR)
docker build --file ubuntu.Dockerfile -t $(DOCKER_TAG_UBUNTU)-build --target build $(BUILD_CONTEXT)
docker save $(DOCKER_TAG_UBUNTU)-build | gzip > $@

# Alpine x86_64
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine.tar.gz: $(BUILD_CONTEXT)/alpine $(OUTPUT_DIR)
docker build -t $(DOCKER_TAG_ALPINE) --target runtime $(BUILD_ARGS_ALPINE)
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine.tar.gz: alpine.Dockerfile $(BUILD_CONTEXT)/crystal-amd64.tar.gz $(OUTPUT_DIR)
docker build --file alpine.Dockerfile -t $(DOCKER_TAG_ALPINE) --target runtime $(BUILD_CONTEXT)
docker save $(DOCKER_TAG_ALPINE) | gzip > $@

$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine-build.tar.gz: $(BUILD_CONTEXT)/alpine $(OUTPUT_DIR)
docker build -t $(DOCKER_TAG_ALPINE)-build --target build $(BUILD_ARGS_ALPINE)
$(OUTPUT_DIR)/docker-$(CRYSTAL_VERSION)-alpine-build.tar.gz: alpine.Dockerfile $(BUILD_CONTEXT)/crystal-amd64.tar.gz $(OUTPUT_DIR)
docker build --file alpine.Dockerfile -t $(DOCKER_TAG_ALPINE)-build --target build $(BUILD_CONTEXT)
docker save $(DOCKER_TAG_ALPINE)-build | gzip > $@

alpine-84codes: ## Build and push docker build images based on the base images from 84codes
Expand Down
8 changes: 4 additions & 4 deletions docker/alpine.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG base_docker_image=alpine:3.22
FROM ${base_docker_image} as runtime
FROM ${base_docker_image} AS runtime
ARG llvm_version=20

RUN \
Expand All @@ -11,8 +11,8 @@ RUN \
# dev tools
make git

ARG crystal_targz
COPY ${crystal_targz} /tmp/crystal.tar.gz
ARG TARGETARCH
COPY crystal-${TARGETARCH}.tar.gz /tmp/crystal.tar.gz

RUN \
tar -xz -C /usr --strip-component=1 -f /tmp/crystal.tar.gz \
Expand All @@ -23,7 +23,7 @@ RUN \

CMD ["/bin/sh"]

FROM runtime as build
FROM runtime AS build

RUN \
apk add --update --no-cache --force-overwrite \
Expand Down
8 changes: 4 additions & 4 deletions docker/ubuntu.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG base_docker_image=ubuntu:24.04
FROM ${base_docker_image} as runtime
FROM ${base_docker_image} AS runtime
ARG llvm_version=20

RUN \
Expand All @@ -11,16 +11,16 @@ RUN \
libpcre3-dev libpcre2-dev libz-dev libgc-dev && \
apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

ARG crystal_targz
COPY ${crystal_targz} /tmp/crystal.tar.gz
ARG TARGETARCH
COPY crystal-${TARGETARCH}.tar.gz /tmp/crystal.tar.gz

RUN \
tar -xz -C /usr --strip-component=1 -f /tmp/crystal.tar.gz && \
rm /tmp/crystal.tar.gz

CMD ["/bin/sh"]

FROM runtime as build
FROM runtime AS build

RUN \
apt-get update && \
Expand Down