-
Notifications
You must be signed in to change notification settings - Fork 24
Replace paste
by with_builtin_macros
.
#1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, let's see how maintained with_builtin_macros
is, but for now that seems a great solution! :)
And that works without nightly, so that's nice.
Are you aware of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_builtin_macros
doesn't look great 😬
Did you try the macro_metavar_expr_concat
? If that works, I think it would be the better option.
Looks like it does what we need, thanks! If we are ok to use something experimental, I'll try it. |
Not that I am expert, but in the same thread that talks about |
The suggestion comes from the author of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are ok to use something experimental, I'll try it.
If it works, I think something experimental here within the language feels better than a 3rd party crate. We're on nightly anyway.
Yes it works, let's merge then! |
Fixes #1379.
I looked for a solution without introducing a new dependency.
concat_idents
seems like a good candidate but it doesn't work for function names as discussed in rust-lang/rust#29599. So I replacedpaste
bywith_builtin_macros
which builts on top ofconcat_idents
to provide the functionality we need.