Adjust keychainAccess impls to refactored keychain api

[infeo]

See cryptomator/integrations-api#56 for more details

[coderabbitai]

Walkthrough

The changes update the Maven pom.xml file to use version 1.6.0 of the integrations-api dependency, replacing the previous 1.5.1 version. In the Java classes GnomeKeyringKeychainAccess and KDEWalletKeychainAccess, the explicit displayName() methods are removed and replaced with @DisplayName annotations specifying the respective names. Additionally, the storePassphrase method signatures in both classes are modified to remove the final boolean parameter, with the method bodies adjusted to match the new signatures. No other modifications are present.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 826e29d and f32087e.

📒 Files selected for processing (3)

• pom.xml (1 hunks)
• src/main/java/org/cryptomator/linux/keychain/GnomeKeyringKeychainAccess.java (3 hunks)
• src/main/java/org/cryptomator/linux/keychain/KDEWalletKeychainAccess.java (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyse

🔇 Additional comments (7)

pom.xml (1)

43-43:

❓ Verification inconclusive

Dependency version update looks good.

The version bump from 1.5.1 to 1.6.0 aligns with the keychain API refactoring mentioned in the PR description and enables the new features used in the keychain access classes.

Please verify that version 1.6.0 of the integrations-api dependency exists and check for any security vulnerabilities:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify the integrations-api version 1.6.0 exists and check for vulnerabilities

# Search for the actual dependency usage
rg "integrations-api" --type xml -A 3 -B 1

# Look for any related API changes in the referenced classes
ast-grep --pattern 'import org.cryptomator.integrations.$_.$_'

Length of output: 8048

---

Dependency version bump confirmed — manual verification required

The integrations-api property in pom.xml (line 43) is correctly updated from 1.5.1 to 1.6.0, and all existing imports of org.cryptomator.integrations.* remain valid.

Please verify that:

• Version 1.6.0 of org.cryptomator:integrations-api is published in your Maven repositories (e.g., Maven Central or your internal Nexus/Artifactory).
• There are no known security vulnerabilities or unresolved CVEs affecting this release.

src/main/java/org/cryptomator/linux/keychain/KDEWalletKeychainAccess.java (3)

3-3: Good addition of DisplayName import.

The import supports the new annotation-based approach for specifying display names.

---

24-24: Excellent migration to @DisplayName annotation.

Using the @DisplayName("KDE Wallet") annotation is cleaner and more declarative than overriding a displayName() method. This follows modern annotation-based configuration patterns.

---

48-48:

✅ Verification successful

Method signature simplification looks correct.

The removal of the boolean parameter from the storePassphrase method signature aligns with the API refactoring. The method implementation correctly handles the simplified signature.

Verify that all callers of this method have been updated to match the new signature:

---

🏁 Script executed:

#!/bin/bash
# Description: Search for any calls to storePassphrase that might still use the old signature

# Search for storePassphrase method calls
rg "storePassphrase\s*\(" -A 2 -B 1

# Look for any remaining 4-parameter calls that might break
ast-grep --pattern 'storePassphrase($_, $_, $_, $_)'

Length of output: 2254

---

All storePassphrase calls updated
Verified that no four-parameter invocations remain and all usages now match the new three-parameter signature.

src/main/java/org/cryptomator/linux/keychain/GnomeKeyringKeychainAccess.java (3)

4-4: Consistent import addition.

The DisplayName import matches the pattern used in the KDE wallet implementation, maintaining consistency across keychain providers.

---

18-18: Consistent use of @DisplayName annotation.

The @DisplayName("GNOME Keyring") annotation follows the same pattern as the KDE wallet implementation, providing a clean, declarative approach to specify the display name.

---

48-48: Method signature consistently refactored.

The storePassphrase method signature has been consistently simplified across both keychain implementations by removing the boolean parameter. The implementation correctly uses the simplified signature.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.