Feature: Dagger 2.55

[infeo]

This PR updates dagger to version 2.55.

The new dagger version allows the usage of classes from jakarta.inject dependency instead of javax.*. Unfortunately, internally dagger still uses javax.inject, hence the old dependency cannot be removed.

Apart from the migration for build the property -Adagger.useBindingGraphFix=ENABLED is set, because this option will be the default in the future anyway.

[coderabbitai]

Walkthrough

The pull request performs namespace updates for dependency injection throughout the project. In the pom.xml file, a compiler argument is added to enable Dagger’s binding graph fix. Additionally, the module declaration in module-info.java now requires jakarta.inject. Across multiple Java source files, import statements for dependency injection annotations – such as Inject, Singleton, Scope, Named, and Qualifier – have been updated from the javax.inject package to the jakarta.inject package. In one instance, a method in the AttributeViewModule class was adjusted to accept a map of concrete instances rather than a map of providers. No changes were made to the core logic or functionality of the classes; the modifications solely involve transitioning to the newer Jakarta EE namespaces and updating configuration parameters.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe47b56 and fa47bc5.

📒 Files selected for processing (69)

• pom.xml (2 hunks)
• src/main/java/module-info.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CopyOperation.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileStore.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileSystemImpl.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileSystemProviderComponent.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileSystemScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileSystemStats.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoFileSystems.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoPathFactory.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/CryptoPathMapper.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/DirectoryIdBackup.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/DirectoryIdLoader.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/DirectoryIdProvider.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/FileNameDecryptor.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/GlobToRegexConverter.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/LongFileNameProvider.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/MoveOperation.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/PathMatcherFactory.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/PathToVault.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/ReadonlyFlag.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/Symlinks.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeByNameProvider.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeComponent.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeModule.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeProvider.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeViewModule.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeViewProvider.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeViewScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/CryptoBasicFileAttributeView.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/CryptoDosFileAttributeView.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/CryptoFileOwnerAttributeView.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/CryptoPosixFileAttributeView.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/ch/ChannelScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/ch/CleartextFileChannel.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/common/FinallyUtil.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/BrokenDirectoryFilter.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/C9rConflictResolver.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/C9rDecryptor.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/C9rProcessor.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/C9sInflator.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/C9sProcessor.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/CiphertextDirectoryDeleter.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/CryptoDirectoryStream.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamComponent.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamFactory.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/dir/NodeProcessor.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/BufferPool.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/ChunkCache.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/ChunkIO.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/ChunkLoader.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/ChunkSaver.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/CurrentOpenFilePath.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/ExceptionsDuringWrite.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/FileHeaderHolder.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OpenCryptoFile.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OpenCryptoFiles.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OpenFileModifiedDate.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OpenFileScoped.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OpenFileSize.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/fh/OriginalOpenFilePath.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/migration/Migrators.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/migration/v6/Version6Migrator.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/migration/v7/Version7Migrator.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/migration/v8/Version8Migrator.java (1 hunks)
• src/main/java/org/cryptomator/cryptofs/attr/AttributeViewModule.java (1 hunks)
• pom.xml (1 hunks)

🔇 Additional comments (71)

src/main/java/org/cryptomator/cryptofs/CryptoFileSystemScoped.java (1)

8-8: Transition to Jakarta EE annotations.
The import for the Scope annotation has been updated from the legacy javax.inject.Scope to jakarta.inject.Scope, aligning this file with the project's overall migration to Jakarta EE.

src/main/java/org/cryptomator/cryptofs/ch/ChannelScoped.java (1)

3-3: Updated import for dependency injection.
The Scope annotation is now imported from jakarta.inject.Scope, ensuring consistency with the new Jakarta EE standards across the codebase.

src/main/java/org/cryptomator/cryptofs/fh/OpenFileSize.java (1)

8-8: Switch to Jakarta Qualifier.
The import for Qualifier has been updated from javax.inject.Qualifier to jakarta.inject.Qualifier, which is in line with the project's migration toward Jakarta EE specifications.

src/main/java/org/cryptomator/cryptofs/fh/BufferPool.java (1)

6-6: Migrated injection annotation import.
The injection annotation has been updated to jakarta.inject.Inject from the old namespace. This change correctly aligns with the new dependency injection standards adopted across the project.

src/main/java/org/cryptomator/cryptofs/attr/AttributeViewScoped.java (1)

3-3: Utilize Jakarta EE Scope annotation.
The import for Scope is now sourced from jakarta.inject.Scope, ensuring that this annotation is consistent with the updated dependency injection framework used throughout the codebase.

src/main/java/org/cryptomator/cryptofs/attr/AttributeScoped.java (1)

3-3: Updated Scope Import to Jakarta Namespace:
The Scope annotation import has been updated from javax.inject.Scope to jakarta.inject.Scope, which is consistent with the migration to the Jakarta EE specifications.

src/main/java/org/cryptomator/cryptofs/fh/OpenFileModifiedDate.java (1)

3-3: Updated Qualifier Import to Jakarta Namespace:
The Qualifier annotation is now imported from jakarta.inject.Qualifier instead of javax.inject.Qualifier. This aligns with the overall namespace transition for dependency injection in the project.

src/main/java/org/cryptomator/cryptofs/CryptoPathMapper.java (1)

22-22: Revised Dependency Injection Import:
The injection annotation import on line 22 has been updated to jakarta.inject.Inject, ensuring consistency with the project's migration from javax.inject to jakarta.inject.

src/main/java/org/cryptomator/cryptofs/PathMatcherFactory.java (1)

3-4: Dependency Injection Annotations Updated:
The imports for Inject and Singleton have been changed to jakarta.inject.Inject and jakarta.inject.Singleton, respectively. This update is in line with the overall move to use Jakarta EE specifications for dependency injection.

src/main/java/org/cryptomator/cryptofs/fh/OpenFileScoped.java (1)

3-3: Scope Import Updated:
The import for the Scope annotation has been updated to jakarta.inject.Scope to reflect the migration from Java EE to Jakarta EE, matching similar changes in other parts of the codebase.

src/main/java/org/cryptomator/cryptofs/CryptoPathFactory.java (1)

5-5: Updated Jakarta DI Annotation

The import has been correctly updated to use jakarta.inject.Inject instead of the old Java EE namespace. This change aligns with the project-wide migration to the Jakarta specifications.

src/main/java/org/cryptomator/cryptofs/dir/C9sInflator.java (1)

12-13: Updated Dependency Injection Imports

The import statements have been updated to use jakarta.inject.Inject and jakarta.inject.Named. This ensures consistency with the new Dagger version and the overall migration to Jakarta EE dependency injection annotations.

src/main/java/org/cryptomator/cryptofs/DirectoryIdProvider.java (1)

17-17: Transition to Jakarta DI

The import statement for Inject has been updated to jakarta.inject.Inject, which is now used consistently across the project.

src/main/java/org/cryptomator/cryptofs/fh/OriginalOpenFilePath.java (1)

8-8: Updated Qualifier Annotation

The file now imports jakarta.inject.Qualifier instead of the javax.inject.Qualifier. This change supports the broader migration to the Jakarta EE namespace and ensures consistency with similar updates in other parts of the codebase.

src/main/java/org/cryptomator/cryptofs/migration/v6/Version6Migrator.java (1)

18-18: Injection Annotation Updated

The import of Inject has been revised to jakarta.inject.Inject, aligning the migrator implementation with the new dependency injection framework and the project's overall upgrade.

src/main/java/org/cryptomator/cryptofs/Symlinks.java (1)

7-7: Updated Dependency Injection Import.
The import statement has been updated from javax.inject.Inject to jakarta.inject.Inject. This change aligns the file with the new Jakarta EE dependency injection framework as required for Dagger 2.55.

src/main/java/org/cryptomator/cryptofs/fh/ChunkCache.java (1)

10-10: Transition to Jakarta Dependency Injection.
The import statement now uses jakarta.inject.Inject instead of javax.inject.Inject, ensuring that ChunkCache is consistent with the updated dependency injection standard.

src/main/java/org/cryptomator/cryptofs/fh/CurrentOpenFilePath.java (1)

3-3: Updated Qualifier Annotation Import.
The import for Qualifier has been updated to jakarta.inject.Qualifier, which aligns with the migration to the Jakarta EE namespace for dependency injection.

src/main/java/org/cryptomator/cryptofs/fh/ChunkSaver.java (1)

6-6: Migrated to Jakarta Injection.
The change from javax.inject.Inject to jakarta.inject.Inject ensures that ChunkSaver now properly references the updated dependency injection framework required for the Dagger 2.55 update.

src/main/java/org/cryptomator/cryptofs/migration/Migrators.java (1)

20-20: Dependency Injection Import Updated.
The Inject annotation import has been replaced with jakarta.inject.Inject in line 20, which is part of the broader update to transition to Jakarta EE for dependency injection.

src/main/java/org/cryptomator/cryptofs/DirectoryIdLoader.java (1)

7-7: Update Dependency Injection Import

The import change from javax.inject.Inject to jakarta.inject.Inject is correctly implemented. This update aligns with the broader migration to Jakarta EE and requires no further modifications in this file.

src/main/java/org/cryptomator/cryptofs/attr/AttributeByNameProvider.java (1)

15-15: Update Dependency Injection Import

The modified import (jakarta.inject.Inject) correctly replaces the deprecated javax.inject.Inject. This change is consistent with the overall migration effort to Jakarta EE dependency injection.

src/main/java/org/cryptomator/cryptofs/fh/FileHeaderHolder.java (1)

11-11: Correct Update of Dependency Injection Import

The import update from javax.inject.Inject to jakarta.inject.Inject is properly applied. The DI setup in the constructor remains unaffected and functions as expected.

src/main/java/org/cryptomator/cryptofs/ReadonlyFlag.java (1)

6-6: Consistency in Dependency Injection Import

The change to jakarta.inject.Inject on line 6 ensures that this file now uses the updated Jakarta namespace. This modification is both correct and consistent with the rest of the codebase.

src/main/java/org/cryptomator/cryptofs/fh/ChunkIO.java (1)

3-3: Update to Jakarta Injection Import

The updated import statement on line 3 switching to jakarta.inject.Inject is correctly implemented. The dependency injection mechanism in this class remains intact with no adverse effects.

src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamScoped.java (1)

3-3: Update Dependency Injection Annotation Import

The import statement for Scope has been updated to jakarta.inject.Scope to reflect the migration from Java EE to Jakarta EE. This change is consistent with similar updates across the project.

src/main/java/org/cryptomator/cryptofs/FileNameDecryptor.java (1)

11-11: Switch to Jakarta Inject Annotation

The injection annotation import has been successfully updated to jakarta.inject.Inject. This ensures that the dependency injection mechanism now uses the Jakarta namespace, in line with the overall migration effort.

src/main/java/org/cryptomator/cryptofs/attr/AttributeComponent.java (1)

7-7: Update of Named Annotation Import

The updated import for Named now uses jakarta.inject.Named instead of the old javax.inject.Named, aligning with the Jakarta EE specifications. This update is straightforward and complies with the migration objectives.

src/main/java/org/cryptomator/cryptofs/dir/NodeProcessor.java (1)

5-6: Correct Jakarta Inject Import Update

The change from javax.inject.Inject to jakarta.inject.Inject in the NodeProcessor class is correct. This update improves consistency across the codebase in terms of dependency injection annotations.

src/main/java/org/cryptomator/cryptofs/CryptoFileSystemImpl.java (1)

25-25: Update Dependency Injection Annotation Import

The import statement for the injection annotation has been updated to jakarta.inject.Inject, ensuring consistency with the migration to Jakarta EE throughout the project. All other aspects of the class remain unchanged.

src/main/java/org/cryptomator/cryptofs/dir/C9sProcessor.java (1)

5-5: Updated DI Import

The import now uses jakarta.inject.Inject in accordance with the Jakarta EE migration objectives. This update is correct and consistent with the overall PR goals.

src/main/java/org/cryptomator/cryptofs/dir/BrokenDirectoryFilter.java (1)

8-8: Replace Deprecated DI Annotation

The import has been updated from javax.inject.Inject to jakarta.inject.Inject, which aligns with the Dagger 2.55 update and Jakarta EE standard.

src/main/java/org/cryptomator/cryptofs/dir/CiphertextDirectoryDeleter.java (2)

7-7: DI Import Migration

The change to import jakarta.inject.Inject is correctly applied. This is an essential part of the project’s shift to the Jakarta EE namespace.

---

22-27: Constructor Injection Validation

The constructor’s use of the @Inject annotation is properly maintained, ensuring that dependency injection continues to function as before.

src/main/java/org/cryptomator/cryptofs/dir/C9rDecryptor.java (1)

10-11: Updated DI Annotations

The import statements for both @Inject and @Named have been updated to use the jakarta.inject package. This change is consistent with the PR’s migration objectives.

src/main/java/org/cryptomator/cryptofs/CryptoFileStore.java (1)

13-13: Dependency Injection Import Revised

The import statement is now updated to jakarta.inject.Inject, aligning this file with the new Jakarta EE standards required by the update.

src/main/java/org/cryptomator/cryptofs/PathToVault.java (1)

8-8: Update DI Annotation Import to Jakarta
The import change from the old javax.inject.Qualifier to jakarta.inject.Qualifier is correctly applied. This update aligns with the overall migration strategy towards Jakarta EE.

src/main/java/org/cryptomator/cryptofs/CopyOperation.java (1)

5-6: Transition to Jakarta DI Imports
The updates replacing javax.inject.Inject and javax.inject.Singleton with their jakarta.inject counterparts are appropriate and consistent with the project-wide migration.

src/main/java/org/cryptomator/cryptofs/dir/CryptoDirectoryStream.java (1)

14-15: Update DI Annotations to Jakarta
Switching the imports of Inject and Named to jakarta.inject.Inject and jakarta.inject.Named respectively is correct. Ensure that dependency injection works seamlessly with the updated namespace.

src/main/java/org/cryptomator/cryptofs/ch/CleartextFileChannel.java (1)

19-19: Migrate DI Import to Jakarta
The migration from javax.inject.Inject to jakarta.inject.Inject on line 19 is implemented properly. This change is straightforward and supports the overall upgrade to Jakarta EE.

src/main/java/org/cryptomator/cryptofs/migration/v8/Version8Migrator.java (1)

20-20: Align with Jakarta Dependency Injection Standards
The update of the import statement for Inject to jakarta.inject.Inject is consistent with similar changes across the codebase. This helps ensure that the dependency injection framework matches the Jakarta EE specifications post-migration.

src/main/java/org/cryptomator/cryptofs/LongFileNameProvider.java (1)

17-17: Update Dependency Injection Import
The import statement has been updated from the legacy javax.inject.Inject to jakarta.inject.Inject, which is fully aligned with the Jakarta EE dependency injection approach.

src/main/java/org/cryptomator/cryptofs/attr/CryptoBasicFileAttributeView.java (1)

17-17: Switch to Jakarta Annotation
The Inject annotation import was changed to use jakarta.inject.Inject. This update helps maintain consistency across the codebase as part of the Jakarta migration effort.

src/main/java/org/cryptomator/cryptofs/attr/AttributeProvider.java (1)

18-18: Dependency Injection Namespace Update
The import now points to jakarta.inject.Inject rather than javax.inject.Inject. This change is part of the overall strategy to transition to Jakarta EE standards.

src/main/java/org/cryptomator/cryptofs/fh/OpenCryptoFile.java (1)

9-9: Migrated to Jakarta DI
The updated import for the Inject annotation to jakarta.inject.Inject aligns with our migration plan. Verify that all corresponding dependency injection configurations are updated accordingly.

src/main/java/org/cryptomator/cryptofs/fh/ExceptionsDuringWrite.java (2)

5-6: Adopt Jakarta Annotation
The import for the Inject annotation has been updated to jakarta.inject.Inject in this file, which is consistent with the Jakarta EE migration across the project.

---

17-17: Constructor Annotation Check
The constructor continues to use the @Inject annotation. Ensure that all dependency injection bindings and consumers are updated to work with the Jakarta namespace.

src/main/java/org/cryptomator/cryptofs/MoveOperation.java (1)

5-6: Update Dependency Injection Imports

The import statements have been correctly updated from javax.inject to jakarta.inject. This change is consistent with the broader migration effort. Please ensure that all dependent classes are similarly updated across the codebase.

src/main/java/org/cryptomator/cryptofs/CryptoFileSystems.java (1)

12-13: Update Dependency Injection Imports

The DI annotations are now imported from jakarta.inject (both Inject and Singleton). This update is properly applied to maintain consistency with the new Jakarta EE namespace.

src/main/java/org/cryptomator/cryptofs/fh/ChunkLoader.java (1)

9-10: Consistent Jakarta EE Dependency Injection Imports

The changes replacing the old javax.inject annotations with jakarta.inject for both Inject and Named are correct and align with the project's dependency injection migration requirements.

src/main/java/org/cryptomator/cryptofs/attr/CryptoFileOwnerAttributeView.java (1)

17-17: Updated Inject Import to Jakarta Namespace

The import for Inject has been updated to jakarta.inject.Inject, and it integrates seamlessly within the file. This change is in line with the project-wide migration strategy.

src/main/java/org/cryptomator/cryptofs/migration/v7/Version7Migrator.java (1)

23-23: Migrator Dependency Injection Import Updated

The import statement for Inject has been updated from the legacy Java EE namespace to jakarta.inject.Inject, which correctly reflects the migration effort. All associated dependency injection usages should be compatible as a result.

src/main/java/org/cryptomator/cryptofs/CryptoFileSystemProviderComponent.java (1)

6-6: Update Dependency Injection Import
Changed the import from javax.inject.Singleton to jakarta.inject.Singleton. This update aligns with the PR objectives to use Jakarta EE annotations and ensures consistency with the new Dagger version 2.55.

src/main/java/org/cryptomator/cryptofs/CryptoFileSystemStats.java (1)

7-7: Switch to Jakarta for @Inject
Updated the import to jakarta.inject.Inject, which is fully consistent with the updated dependency injection strategy across the codebase.

src/main/java/org/cryptomator/cryptofs/attr/AttributeModule.java (1)

11-11: Transition to Jakarta's @nAmed Import
The change from javax.inject.Named to jakarta.inject.Named is a straightforward update that supports the overall migration strategy and ensures consistency.

src/main/java/org/cryptomator/cryptofs/attr/AttributeViewProvider.java (1)

16-16: Update to Jakarta's @Inject Annotation
Replaced the old import with jakarta.inject.Inject, meeting the project’s migration objectives and maintaining a consistent dependency injection API across modules.

src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamFactory.java (1)

9-9: Update Jakarta Injection Import
Modified the import to jakarta.inject.Inject, which aligns with the broader effort of transitioning from Javax to Jakarta namespaces across the project.

src/main/java/org/cryptomator/cryptofs/dir/DirectoryStreamComponent.java (1)

6-6: Dependency Injection Annotation Update.
The replacement of javax.inject.Named with jakarta.inject.Named is properly applied and aligns with the overall Jakarta EE migration strategy.

src/main/java/org/cryptomator/cryptofs/DirectoryIdBackup.java (1)

9-9: DI Import Modernization.
The update from javax.inject.Inject to jakarta.inject.Inject is correctly implemented and ensures consistency with the project's move to Jakarta EE specifications.

src/main/java/org/cryptomator/cryptofs/attr/CryptoDosFileAttributeView.java (1)

17-17: Updated Dependency Injection Import.
Changing the injection import to jakarta.inject.Inject is in line with the overall migration; the update is clean and does not affect functionality.

src/main/java/org/cryptomator/cryptofs/fh/OpenCryptoFiles.java (1)

14-14: Consistent DI Annotation Upgrade.
The revised import statement import jakarta.inject.Inject; ensures that the dependency injection framework remains current and consistent. There are no adverse side effects observed.

src/main/java/org/cryptomator/cryptofs/dir/C9rProcessor.java (1)

5-5: DI Annotation Consistency.
The change to import jakarta.inject.Inject; correctly reflects the migration from javax.* to jakarta.* and maintains consistency across the codebase.

src/main/java/org/cryptomator/cryptofs/attr/CryptoPosixFileAttributeView.java (1)

17-17: LGTM - Consistent namespace migration

The import statement has been correctly updated from javax.inject.Inject to jakarta.inject.Inject as part of the Dagger 2.55 migration.

src/main/java/module-info.java (1)

22-22: LGTM - Appropriate module requirement added

The jakarta.inject requirement has been correctly added while maintaining the existing javax.inject dependency, which aligns with the PR objectives. As noted in the comments, both are needed since Dagger still internally relies on javax.inject.

src/main/java/org/cryptomator/cryptofs/dir/C9rConflictResolver.java (1)

16-17: LGTM - Consistent namespace migration

The import statements have been correctly updated from javax.inject.* to jakarta.inject.* as part of the Dagger 2.55 migration.

src/main/java/org/cryptomator/cryptofs/common/FinallyUtil.java (1)

3-4: LGTM - Consistent namespace migration

The import statements have been correctly updated from javax.inject.* to jakarta.inject.* as part of the Dagger 2.55 migration.

src/main/java/org/cryptomator/cryptofs/GlobToRegexConverter.java (1)

3-4: Updated dependency injection imports to use Jakarta namespace.

The import statements have been correctly updated from javax.inject to jakarta.inject to align with the Dagger 2.55 update mentioned in the PR objectives.

pom.xml (3)

23-23: Dagger version upgrade from 2.51.1 to 2.55.

This version upgrade aligns with the PR objectives to update the Dagger library.

---

94-98: Added Jakarta Inject API dependency.

A new dependency for Jakarta Inject API v2.0.1 has been correctly added to support the transition from javax.inject to jakarta.inject as mentioned in the PR objectives.

---

190-190: Added Dagger binding graph fix compiler argument.

The compiler argument -Adagger.useBindingGraphFix=ENABLED has been added, which aligns with the PR objectives to set this property that will be the default in future Dagger releases.

src/main/java/org/cryptomator/cryptofs/attr/AttributeViewModule.java (1)

47-53: Simplified attribute view retrieval by removing provider indirection.

The method now accepts a map of direct FileAttributeView instances rather than providers, simplifying the code by eliminating an unnecessary layer of indirection. This change improves readability and may have a small performance benefit by avoiding the provider call.

The change is consistent with modern dependency injection patterns where concrete instances can be directly injected when they're already available, rather than using providers unnecessarily.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.