Problem: gRPC server should not be recommended to be enabled by default#80
Open
calvinaco wants to merge 4 commits intocrypto-org-chain:masterfrom
Open
Problem: gRPC server should not be recommended to be enabled by default#80calvinaco wants to merge 4 commits intocrypto-org-chain:masterfrom
calvinaco wants to merge 4 commits intocrypto-org-chain:masterfrom
Conversation
Solution: Update to recommend disable gRPC server
calvinaco
changed the title
Contributor
Author
|
/staging |
Contributor
Author
|
/staging |
tomtau
reviewed
Nov 29, 2021
Contributor
tomtau
left a comment
tomtau
left a comment
There was a problem hiding this comment.
should API etc. also be disabled on public nodes? or some other recommendation -- e.g. IP-restrict it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Update to recommend disable gRPC server