Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Custom Targets): restrict Custom Targets domains #444

Merged
merged 17 commits into from
May 29, 2024

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented May 8, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #323

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

mentioned by: @andrewazores #323

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@aali309 aali309 added feat New feature or request safe-to-test labels May 8, 2024
@aali309 aali309 marked this pull request as ready for review May 8, 2024 21:04
@aali309
Copy link
Contributor Author

aali309 commented May 8, 2024

/build_test

Copy link

github-actions bot commented May 8, 2024

Workflow started at 5/8/2024, 5:05:22 PM. View Actions Run.

Copy link

github-actions bot commented May 8, 2024

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9008522991

1 similar comment
Copy link

github-actions bot commented May 8, 2024

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9008522991

@aali309
Copy link
Contributor Author

aali309 commented May 8, 2024

/build_test

Copy link

github-actions bot commented May 8, 2024

Workflow started at 5/8/2024, 5:57:45 PM. View Actions Run.

Copy link

github-actions bot commented May 8, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented May 8, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented May 8, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9009057840

@aali309 aali309 requested a review from andrewazores May 8, 2024 22:05
@aali309
Copy link
Contributor Author

aali309 commented May 8, 2024

@andrewazores please let me know if this matches what you suggested :)

@aali309 aali309 force-pushed the restrictCustomTargetsDomains branch 2 times, most recently from f1d7580 to c4b7325 Compare May 9, 2024 18:16
@aali309
Copy link
Contributor Author

aali309 commented May 9, 2024

/build_test

Copy link

github-actions bot commented May 9, 2024

Workflow started at 5/9/2024, 2:17:58 PM. View Actions Run.

Copy link

github-actions bot commented May 9, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented May 9, 2024

No GraphQL schema changes detected.

Copy link

github-actions bot commented May 9, 2024

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9021675054

@aali309 aali309 force-pushed the restrictCustomTargetsDomains branch 2 times, most recently from f1d7580 to 9304827 Compare May 9, 2024 18:33
@aali309
Copy link
Contributor Author

aali309 commented May 9, 2024

/build_test

Copy link

github-actions bot commented May 9, 2024

Workflow started at 5/9/2024, 2:34:49 PM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9258630230

@aali309 aali309 force-pushed the restrictCustomTargetsDomains branch from e802b4a to 9a0f825 Compare May 28, 2024 14:04
@andrewazores
Copy link
Member

Refactoring suggestions: https://github.com/aali309/cryostat3/pull/21/files

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 5/29/2024, 1:31:02 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9290556247

@andrewazores andrewazores merged commit d49402f into cryostatio:main May 29, 2024
8 checks passed
@aali309 aali309 deleted the restrictCustomTargetsDomains branch May 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Request] Restrict Custom Targets domains
2 participants