Skip to content

refact pkg/parser: extract method, avoid calling defer in loop #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Apr 9, 2025

No description provided.

@mmetc mmetc added this to the 1.6.9 milestone Apr 9, 2025
Copy link

github-actions bot commented Apr 9, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Apr 9, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 59.21053% with 31 lines in your changes missing coverage. Please review.

Project coverage is 57.83%. Comparing base (4004868) to head (3617ec4).

Files with missing lines Patch % Lines
pkg/parser/stage.go 58.66% 21 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
+ Coverage   57.82%   57.83%   +0.01%     
==========================================
  Files         391      391              
  Lines       43728    43741      +13     
==========================================
+ Hits        25284    25298      +14     
- Misses      16300    16301       +1     
+ Partials     2144     2142       -2     
Flag Coverage Δ
bats 42.71% <56.57%> (+0.03%) ⬆️
unit-linux 32.99% <59.21%> (+0.01%) ⬆️
unit-windows 22.69% <59.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc marked this pull request as draft April 9, 2025 07:44
@mmetc mmetc marked this pull request as ready for review April 15, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant